Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(ArrayField): add support for storeKey to manage independent selection states #10390

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Chore(ArrayField): add support for storeKey to manage independent selection states #10390

wants to merge 4 commits into from

Conversation

Aijeyomah
Copy link

@Aijeyomah Aijeyomah commented Dec 1, 2024 •
edited
Loading

Problem

#10382
Describe the problem this PR solves

Solution

  • Introduced a storeKey property for ArrayField to enable distinct selection state storage for multiple instances of the same data source.
  • Added documentation and examples to demonstrate usage.

Describe the solution this PR implements

How To Test

Describe the steps required to test the changes

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@Aijeyomah Aijeyomah changed the title chore: add storeKey to arrayfield to handle resources with same ids **Chore(ArrayField): add support for storeKey to manage independent selection states** Dec 1, 2024
@Aijeyomah Aijeyomah changed the title **Chore(ArrayField): add support for storeKey to manage independent selection states** Chore(ArrayField): add support for storeKey to manage independent selection states Dec 1, 2024
@Aijeyomah
Copy link
Author

Aijeyomah commented Dec 4, 2024 •
edited
Loading

@fzaninotto Can you review? thanks

@djhi
Copy link
Collaborator

djhi commented Dec 4, 2024

Thanks for the PR! As this is a new feature, can you target the next branch? Besides, in order to test it, we'll need stories and unit tests. Can you add some, taking inspiration from the ListBase component?

@Aijeyomah
Copy link
Author

Thanks for the PR! As this is a new feature, can you target the next branch? Besides, in order to test it, we'll need stories and unit tests. Can you add some, taking inspiration from the ListBase component?

Yes, I can. Thanks

@Aijeyomah Aijeyomah changed the base branch from master to next December 17, 2024 10:02
@Aijeyomah Aijeyomah force-pushed the add-storekey-to-arrayfield branch from d8c1f4f to d852f0c Compare January 2, 2025 13:32
@Aijeyomah
Copy link
Author

Thanks for the PR! As this is a new feature, can you target the next branch? Besides, in order to test it, we'll need stories and unit tests. Can you add some, taking inspiration from the ListBase component?

@djhi @fzaninotto I have updated the target branch as well as written the necessary stories and tests for the feature. Please re-review. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aijeyomah @djhi